-
Notifications
You must be signed in to change notification settings - Fork 63
Update must-gather and operator ubi references to ubi 10 #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
This commit updates ubi reference from 9.6-1760340943 to 10.1-1762189261. Signed-off-by: Daniel Kreling <[email protected]>
Dockerfile
Outdated
|
|
||
| # Use OpenShift base image | ||
| FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1760515502 | ||
| FROM registry.access.redhat.com/ubi10/ubi-minimal:10.1-1762189261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is bumping the operator as well, maybe update the patch title to ... (must-gather, operator) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
New changes are detected. LGTM label has been removed. |
|
You will need to add a RPM lockfile for the operator's build now that you install packages in it. |
Dismissing my review as there's obviously more to it...
Signed-off-by: Daniel Kreling <[email protected]>
Signed-off-by: Daniel Kreling <[email protected]>
9e0260f to
5b74626
Compare
|
Last forced push removed the redhat.repo for must-gather and also added "rpms.in.yaml" and "rpms.lock.file". |
Tzdata was stripped down from ubi-minimal version 10 [0]. Although no direct documentation was found for shadow-utils, "useradd" is failing to build, so a direct install is necessary. With those additions, new rpms.in.yaml and rpms.lock.yaml files are necessary. [0] https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/10/html/considerations_in_adopting_rhel_10/containers Signed-off-by: Daniel Kreling <[email protected]>
5b74626 to
8313e86
Compare
|
@dbkreling: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @dbkreling ! The ci/prow/* jobs are failing because they are still using the rhel-9 buildroot as you suspected. The current base image is I think above is enough, but more things to consider:
|
PR openshift/sandboxed-containers-operator#1367 is bumping OSC versions to ubi and ubi-minimal 10, and we have to bump the base image. Signed-off-by: Daniel Kreling <[email protected]>
PR openshift/sandboxed-containers-operator#1367 is bumping OSC versions to ubi and ubi-minimal 10, and we have to bump the base image. Signed-off-by: Daniel Kreling <[email protected]>
Update ubi reference from 9.6-1760340943 to 10.1-1762189261 on the operator, must-gather and podvm-builder.
Update references to ubi-minimal tags to 10.1-1763362715
Also add the ubi.repo.
Issue: https://issues.redhat.com/browse/KATA-4311