-
Notifications
You must be signed in to change notification settings - Fork 2k
CAPO: Use KUBEBUILDER_ASSETS_DIR instead of XDG_DATA_HOME #44013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KUBEBUILDER_ASSETS_DIR requires backporting kubernetes-sigs/cluster-api-provider-openstack#1710, which will require a separate patch.
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
Whatever this does, the tests are currently broken anyway, and the repo is still not in the OCP payload. Thanks and good luck 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mdbooth, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-sigs/cluster-api-provider-openstack#1710 is merged upstream and included in backport openshift/cluster-api-provider-openstack#265 which is waiting on this PR to hopefully pass. |
/pj-rehearse skip |
@mdbooth: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
KUBEBUILDER_ASSETS_DIR requires backporting
kubernetes-sigs/cluster-api-provider-openstack#1710, which will require a separate patch.