OCPCLOUD-3222: Adds agents.md #1449
Conversation
|
@theobarberbany: This pull request references OCPCLOUD-3222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/override okd-scos-images |
|
@theobarberbany: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@theobarberbany: Overrode contexts on behalf of theobarberbany: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@theobarberbany: This pull request references OCPCLOUD-3222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
theobarberbany
force-pushed
the
tb/add-agents
branch
from
6b7a4a6 to
e841ad6
Compare
|
/skip |
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
/approve
Left a couple of extra details that we may/may not want to add
|
|
||
| | Package | Purpose | | ||
| |---------|---------| | ||
| | `pkg/controller/machine/` | Machine lifecycle (create/delete instances, drain nodes, track phases) | |
There was a problem hiding this comment.
I'd add that this pkg is then imported by the various github.com/openshift/machine-api-provider-* providers that then define the machine-controller (and potentially other provider specific ones) (with exception of the VSphere provider, which is directly hosted in this repo ( pkg/controller/vsphere/).
That controller than gets embedded into its own manager and built into a binary and in turn into a container image. That container image is then referenced by the machine-controllers Deployment operand that this machine-api-operator in turn deploys.
(Feel free to add or drop details as needed, this is only a dump of info), but that's something worthy to explain IMO as that often confuses people.
There was a problem hiding this comment.
this is fairly complex - does this belong in a readme where an agent or human can discover it, vs AGENTS.md?
There was a problem hiding this comment.
have added to readme
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@damdo: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
Adds minimal agents.md for MAO
theobarberbany
force-pushed
the
tb/add-agents
branch
from
e841ad6 to
b14ce90
Compare
openshift-ci-robot
removed
the
verified
|
@theobarberbany: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
lgtm
|
/verified by not needing verification |
openshift-ci-robot
added
the
verified
|
@theobarberbany: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Adds minimal agents.md for MAO
I've asked claude to use the same template / style as CCAPIO but to optimise for agentic AI vs human readability