Skip to content

OCPNODE-3753: CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

OCPNODE-3753: CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication #1861

merged 1 commit into from
Nov 12, 2025

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Oct 13, 2025 •
edited
Loading

Propose a new CRIOCredentialProviderConfig CRD that enables use namespace-scoped secrets for mirror registry authentication.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@QiWang19 QiWang19 changed the title ImageCredentialProviderConfig API for Namespace-Scoped Mirror Authent… ImageCredentialProviderConfig for Namespace-Scoped Mirror Authentication Oct 13, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Oct 13, 2025

/test all

saschagrunert
saschagrunert reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up, it nicely summarizes the whole effort!

@QiWang19 QiWang19 force-pushed the crio-credential-config branch from 060f30d to 7d1b2f9 Compare October 14, 2025 23:04
@QiWang19 QiWang19 marked this pull request as ready for review October 14, 2025 23:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Oct 14, 2025

@saschagrunert PTAL

saschagrunert
saschagrunert approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 👍

@saschagrunert
Copy link
Member

saschagrunert commented Oct 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@bitoku bitoku mentioned this pull request Oct 15, 2025
Open
@QiWang19 QiWang19 changed the title ImageCredentialProviderConfig for Namespace-Scoped Mirror Authentication CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication Oct 15, 2025
@QiWang19 QiWang19 force-pushed the crio-credential-config branch from 7d1b2f9 to 14465a6 Compare October 15, 2025 19:02
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@QiWang19 QiWang19 changed the title CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication OCPNODE-3753: CRIOCredentialProviderConfig for Namespace-Scoped Mirror Authentication Oct 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3753 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Propose a new CRIOCredentialProviderConfig CRD that enables use namespace-scoped secrets for mirror registry authentication.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@saschagrunert
Copy link
Member

saschagrunert commented Oct 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
lyman9966
lyman9966 reviewed Oct 17, 2025
View reviewed changes
@QiWang19 QiWang19 mentioned this pull request Nov 3, 2025
Open
@QiWang19 QiWang19 force-pushed the crio-credential-config branch from 14465a6 to b3ced87 Compare November 4, 2025 21:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

@saschagrunert @lyman9966 PR rebased, PTAL

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

@mrunalp @rphillips could you review and approve?

saschagrunert
saschagrunert approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with non-blocking nits.

@QiWang19 QiWang19 force-pushed the crio-credential-config branch from b3ced87 to 6a0af1e Compare November 5, 2025 17:32
@lyman9966
Copy link

lyman9966 commented Nov 10, 2025

/lgtm from my side

@rphillips
Copy link
Contributor

rphillips commented Nov 11, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2025

/retest-required

Remaining retests: 0 against base HEAD e16826d and 2 for PR HEAD 6a0af1e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0f24726 into openshift:master Nov 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

@dhellmann dhellmann Awaiting requested review from dhellmann

3 more reviewers

@bitoku bitoku bitoku left review comments

@lyman9966 lyman9966 lyman9966 left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rphillips rphillips

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@QiWang19 @saschagrunert @openshift-ci-robot @lyman9966 @rphillips @bitoku