NO-JIRA: Remove ChunkSizeMib featuregate #1240
Conversation
deepsm007
force-pushed
the
remove-chunksizemib-var
branch
2 times, most recently
from
b349985 to
641b9d7
Compare
deepsm007
force-pushed
the
remove-chunksizemib-var
branch
3 times, most recently
from
74bd59a to
9ae0bc1
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
|
/retest |
deepsm007
force-pushed
the
remove-chunksizemib-var
branch
from
340c2b6 to
edba1e4
Compare
|
I have rebased the PR, the previous failures were not related to the code changes. Hypershift test failed due to infrastructure issue, retesting again. |
|
/retest |
deepsm007
force-pushed
the
remove-chunksizemib-var
branch
from
edba1e4 to
41c150c
Compare
|
/retest |
|
/approve |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-vsphere-operator e2e-aws-operator |
|
the e2e-*-operator tests are flaking so much that at this point they're nearly perma-failing, and this isn't the case for this PR only, it's happening across the board. /override ci/prow/e2e-aws-operator |
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator, ci/prow/e2e-vsphere-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
deepsm007
changed the title
deepsm007
force-pushed
the
remove-chunksizemib-var
branch
from
41c150c to
503ccc8
Compare
|
/override ci/prow/e2e-aws-operator |
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator, ci/prow/e2e-vsphere-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, flavianmissi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@deepsm007: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle NO-JIRA: Remove ChunkSizeMib featuregate |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@deepsm007: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
deepsm007
changed the title
deepsm007
changed the title
|
this feature gate has been enabled for a few releases now, so removing it does not affect end users. /label px-approved |
openshift-ci
bot
added
px-approved
|
Hi @xiuwang! Could you please help us with verifying this? It's really just an openshift/api bump, the actual feature gate removal was done in openshift/api#2438. |
|
/retest-required |
|
/verified by @xiuwang |
openshift-ci-robot
added
the
verified
|
@xiuwang: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@xiuwang can you override the one failing test? #1240 (comment) @flavianmissi is not around for several weeks now |
|
/retest-required |
|
@deepsm007: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-gcp-operator |
|
@xiuwang: xiuwang unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@deepsm007 I have no permission to do override |
4 participants
/cc @flavianmissi
wait for openshift/api#2438