Make CLI settings fully dynamic + fix NodeClient typing #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
seankao-az
as code owners
Signed-off-by: Simeon Widdis <[email protected]>
penghuo
approved these changes
Dec 9, 2025
Comment on lines
+35
to
36
| sqlPluginVersion = "3.4.0" | ||
| opensearchClientVersion = '3.2.0' |
Collaborator
There was a problem hiding this comment.
should we also bump opensearchClientVersion?
Collaborator
Author
There was a problem hiding this comment.
Can't, the Java client is no longer receiving updates -- we don't need it to be kept up to date I think
Collaborator
Author
There was a problem hiding this comment.
Have asked about this on OS slack before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor patches for upstream breakage -- CLI settings are fully dynamic now, which will reduce future breakage in this area. NodeClient was updated for the upstream type changes.
Issues Resolved
Test failures in SQL
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.