Fix applying indices on search requests for PIT requests #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
seankao-az
as code owners
Collaborator
Author
|
Added reproducers -- doesn't yet run new tests in CI, that'll be in the future. Fixing a few more bugs in this suite short-term. |
Swiddis
commented
Oct 27, 2025
| Test getting JAR path | ||
| """ | ||
| # Setup mock | ||
| expected_path = "/mock/project_root/build/libs/opensearchsqlcli-3.3.0.0.jar" |
Collaborator
Author
There was a problem hiding this comment.
This breaks every time there's a version bump upstream -- longterm fix for versioning is TODO
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
ps48
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
source=big5;currently fails with[indices] cannot be used with point in time. This boils down to accidentally running these queries directly on the index instead of as a generic_search. This PR adds a tweak to fix this.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.