Fixed bugs in api_generator #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: Wrong type due to SpecHash parsing bug Fixed: Extra space in method description Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
fix/api_generator/workflow
branch
from
b036348 to
f72b1f6
Compare
nhtruong
changed the title
mustache file not found error
nhtruong
requested review from
VijayanB,
robsears,
vamshin,
dblock,
VachaShah,
harshavamsi and
Earlopain
as code owners
dblock
approved these changes
Feb 7, 2025
| end | ||
|
|
||
| def to_s | ||
| "<SpecHash: #{@hash.to_s}>" |
There was a problem hiding this comment.
Suggested change
| "<SpecHash: #{@hash.to_s}>" | |
| "<SpecHash: #{@hash}>" |
Redundant.
| @@ -59,8 +70,8 @@ def parse(value) | |||
| return value unless value.is_a?(Hash) | |||
| ref = value.delete('$ref') | |||
| value.transform_values! { |v| parse(v) } | |||
| return SpecHash.new(value) unless ref | |||
| SpecHash.new(parse(resolve(ref)).merge(value)) | |||
| value.merge!(resolve(ref)) if ref | |||
There was a problem hiding this comment.
Generally modifying value in-place like this is not a good idea, duplicate and return value.
There was a problem hiding this comment.
I agree. This was done intentionally. The SpecHash is my poor-man OpenAPI parser (though 10 times faster than the official tool for ruby) that replaces every object with $ref with the object it references. The original object will be discarded and not to be used by anything else. Hence the in-place update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
mustache file not founderrorFixed: Wrong type due to SpecHash parsing bug
Fixed: Extra space in method description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.