fixes for aggregate command #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
rishabh6788 and
VijayanB
as code owners
IanHoang
reviewed
Aug 19, 2025
osbenchmark/aggregator.py
Outdated
| self.config.add(config.Scope.applicationOverride, "system", | ||
| "env.name", test_run.environment_name) | ||
| self.config.add(config.Scope.applicationOverride, "system", "time.start", current_timestamp) | ||
| self.config.add(config.Scope.applicationOverride, "test_run", "pipeline", test_run.pipeline) | ||
| self.config.add(config.Scope.applicationOverride, "workload", "params", test_run.workload_params) | ||
| self.config.add(config.Scope.applicationOverride, "builder", | ||
| "cluster_config_instance.params", test_run.cluster_config_instance_params) | ||
| "cluster_config.params", test_run.cluster_config) |
There was a problem hiding this comment.
should this be "cluster_config.params", test_run.cluster_config_params?
Signed-off-by: Michael Oviedo <[email protected]>
IanHoang
pushed a commit
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Michael Oviedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes to aggregate command to prevent key errors + update function name for storing aggregated results
Issues Resolved
[List any issues this PR will resolve]
Testing
running aggregate command with changes applied
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.