add checker for 1.x terms #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
rishabh6788 and
VijayanB
as code owners
|
Thanks for doing this @OVI3D0! Might be helpful to include an opposite version, for 2.X terms. This would help whenever users are making changes to 1.X version when 2.X is already out. The 2.X version should only be run if the PR includes:
Lmk your thoughts on this? |
IanHoang
approved these changes
Jul 8, 2025
IanHoang
reviewed
Jul 8, 2025
IanHoang
reviewed
Jul 8, 2025
Signed-off-by: Michael Oviedo <[email protected]>
this would be pretty useful, i'll go ahead and create an issue for it |
gkamat
pushed a commit
that referenced
this pull request
Aug 1, 2025
Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: Ian Hoang <[email protected]>
gkamat
pushed a commit
to gkamat/opensearch-benchmark
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Michael Oviedo <[email protected]>
gkamat
pushed a commit
that referenced
this pull request
Aug 19, 2025
Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: Ian Hoang <[email protected]>
IanHoang
pushed a commit
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: Ian Hoang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a lint checker for 1.x terms. Takes the set of terms described in the issue and checks for any variants of the terms (hyphen, underscore, camelCase, etc). Prints out deprecated terms if they are found
Issues Resolved
#841
Testing
Ran script against 2.0-develop branch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.