Parameterize service.protocol for opensearch-dashboards #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enes Kurtanovic <[email protected]>
Signed-off-by: Enes Kurtanovic <[email protected]>
enes-zed
requested review from
DandyDeveloper,
TheAlgo,
bbarani,
gaiksaya,
peterzhuamazon and
prudhvigodithi
as code owners
TheAlgo
requested changes
May 26, 2024
Member
TheAlgo
left a comment
TheAlgo
left a comment
There was a problem hiding this comment.
LGTM overall. Can you help with completing checklist for the PR?
Member
|
@prudhvigodithi Can you also take a look at this PR? |
Member
|
Hey @enes-zed the LGTM, thanks for your contribution, can you please update the chart README.md, |
Member
|
@enes-zed any update on the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow users to specify the protocol for the service definition, which is currently hardcoded to TCP.
Allows for better integration e.g. with Istio.
Issues Resolved
#532
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.