Remove unnecessary sleep between test runs #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
ohltyler,
owaiskazi19 and
sean-zheng-amazon
as code owners
opensearch-trigger-bot
bot
added
github actions
kaituo
force-pushed
the
CIFix
branch
6 times, most recently
from
3c58a43 to
945dd67
Compare
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]>
dbwiddis
approved these changes
May 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03)
dbwiddis
pushed a commit
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <[email protected]>
jackiehanyang
pushed a commit
to jackiehanyang/anomaly-detection-dashboards-plugin
that referenced
this pull request
Nov 17, 2025
…pensearch-project#754) The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <[email protected]> (cherry picked from commit a6fa630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The introduction of
sleepbetween test runs indashboard_spec.jsanddetector_list_spec.jswas initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257.With the root cause of the failures addressed, the delays introduced by
sleepcommands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions.Testing Done:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.