Imports from companion objects should have supertype information #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-kotlin/src/test/java/org/openrewrite/kotlin/tree/ImportTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Aug 6, 2025
| spec -> spec.afterRecipe(cu -> { | ||
| //noinspection DataFlowIssue | ||
| var supertype = TypeUtils.asFullyQualified(cu.getImports().getFirst().getQualid().getType()).getSupertype(); | ||
| assertThat(supertype).isNotNull(); |
There was a problem hiding this comment.
Currently fails with
| java.lang.AssertionError: | |
|---|---|
| Expecting actual not to be null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Non-star imports in Kotlin now retain not only the type of the imported object (e.g., a companion object), but also its supertypes. This ensures that full type information is available for the imported member.
What's your motivation?
When analyzing a Kotlin file, type information such as
cu.getTypesInUse().getUsedMethods()orcu.getTypesInUse().getVariables()will refer to the method or variable as declared on its actual type. This can be the declaring class, a superclass, or an interface.In Kotlin, this becomes problematic when importing a member from a companion object that implements an interface. The import itself only carries the type of the companion object, not of its supertype. As a result, the type of the used method and the type of the imported symbol don’t match, making it impossible to correlate the import with the usage.
By including supertype information on imported members, this allows recipes to match imports against used methods and variables, even when they’re inherited from a supertype.
Checklist