Fix remove unused imports doc #5738
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2025 09:56
|
with: 
without: 
test working assuming version issue. |
6 tasks
added 2 commits
July 13, 2025 14:57
|
seems consistent: |
timtebeek
reviewed
Jul 16, 2025
Comment on lines
+137
to
+215
| void doNotDocRemoval() { | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| /* | ||
| * Copyright 2015-2025 the original author or authors. | ||
| * | ||
| * All rights reserved. This program and the accompanying materials are | ||
| * made available under the terms of the Eclipse Public License v2.0 which | ||
| * accompanies this distribution and is available at | ||
| * | ||
| * https://www.eclipse.org/legal/epl-v20.html | ||
| */ | ||
|
|
||
| package org.junit.platform.suite.api; | ||
|
|
||
| import static org.apiguardian.api.API.Status.STABLE; | ||
|
|
||
| import java.lang.annotation.Documented; | ||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Inherited; | ||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
| import java.util.Set; | ||
|
|
||
| import org.apiguardian.api.API; | ||
|
|
||
| /** | ||
| * {@code @SelectModules} specifies the modules to <em>select</em> when running | ||
| * a test suite on the JUnit Platform. | ||
| * | ||
| * @since 1.8 | ||
| * @see Suite | ||
| * @see org.junit.platform.engine.discovery.DiscoverySelectors#selectModules(Set) | ||
| */ | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target(ElementType.TYPE) | ||
| @Inherited | ||
| @Documented | ||
| @API(status = STABLE, since = "1.10") | ||
| public @interface SelectModules { | ||
|
|
||
| /** | ||
| * One or more modules to select. | ||
| */ | ||
| String[] value(); | ||
|
|
||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| /** | ||
| * BSD-style license; for more info see http://pmd.sourceforge.net/license.html | ||
| */ | ||
|
|
||
| package net.sourceforge.pmd.lang.java.ast; | ||
|
|
||
| import net.sourceforge.pmd.lang.ast.Node; | ||
|
|
||
| /** | ||
| * The declaration of an annotation type. | ||
| * This is a {@linkplain Node#isFindBoundary() find boundary} for tree traversal methods. | ||
| * </pre> | ||
| * | ||
| */ | ||
| public final class ASTAnnotationTypeDeclaration { | ||
|
|
||
|
|
||
| ASTAnnotationTypeDeclaration(int id) { | ||
| } | ||
|
|
||
| } | ||
| """ | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Thanks for reporting the issue! Can we reduce this down to just the minimum required to replicate the test failure?
4 tasks
@Nested
@Issue("https://github.com/openrewrite/rewrite/pull/5738")
class removeUnusedImportsDoc {
@Test
void usedInDoc() {
rewriteRun(
java(
"""
import java.util.Date;
import java.util.List;
/**
* referencing {@link Date} only in doc
*/
class Test {
List list;
}
"""
)
);
}
@Test
void usedInDocFullQualified() {
rewriteRun(
java(
"""
import java.util.Date;
import java.util.List;
/**
* referencing {@link java.util.Date} only in doc
*/
class Test2 {
List list;
}
""",
"""
import java.util.List;
/**
* referencing {@link java.util.Date} only in doc
*/
class Test2 {
List list;
}
"""
)
);
}
}still the case seem to be fixed, but i came across another issue, not able to fix the impl. Feel free to incorporate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
rewritecapability junit-team/junit-framework#4708What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist