Create type tables for argument GAVs in Maven #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sambsnyd
approved these changes
May 16, 2025
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add a new goal to the rewrite-maven-plugin to create type tables.
What's your motivation?
Parity for folks using Maven, as up to now that had only been available for Gradle.
Anything in particular you'd like reviewers to focus on?
Figured I'd reuse as much as possible, while working around the fact that Maven does not easily allow resolving two versions. By using a profile folks should be able to clearly document the steps to recreate a type table, without it interfering with recipe runs on the same recipe module.
Anyone you would like to review specifically?
@nmck257 I believe this was relevant for you all there right?
Have you considered any alternatives or workarounds?
Briefly explored plugin
<dependency>, but that would not allow for more than one version of an artifact, so figured userecipeArtifactCoordinateswith GAV arguments instead.Any additional context
TypeTableas a substitute for packing whole jars intoMETA-INF/rewrite/classpathrewrite#4932TypeTablerewrite-docs#350