Improve holiday validator & data #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enforce UUID format + global uniqueness; flag missing Ids - Check StartDate ordering and date parsing with clear errors - Require key columns/values and correct CSV line numbers - Consistent CSV handling (UTF-8 BOM), deterministic runs, single success message
Contributor
|
Great. Except 12032ca (see comments there) everything else seems to be right. |
Contributor
|
Will merge everysthing until end of this week |
Contributor
Author
KristjanESPERANTO
force-pushed
the
validator
branch
from
0eaebb7 to
e3938f1
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the validator and added some checks (UUID format + global uniqueness + chronological order).
Running it revealed some data issues which I've fixed in the following commits.
12032ca an af340bf are the interesting data issues. The others are just chores like sorting.
What do you think? 🙂