Skip to content

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Mar 2, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes the completed/ Approved table to display and also handles removal of unneccessay unused code.

Screenshots

Screenshot 2024-03-02 at 11 24 47

Related Issue

Other

@jabahum jabahum requested a review from pirupius March 2, 2024 08:25
@jabahum jabahum self-assigned this Mar 2, 2024
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the cleanup. Left a couple of more comments

Comment on lines 107 to 108
className={styles.statusContainer}
style={{ color: `${getStatusColor(entry.fulfillerStatus)}` }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any extra styles in the statusContainer class? trying to access if it's still relevant after this refactor

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is really relevant since it provides for the background of the table

Comment on lines +7 to +14
"pages": [
{
"component": "root",
"route": "laboratory"
}
],
"extensions": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies to this json file. 2 spaces

@jabahum jabahum force-pushed the add-auto-update-on-tables branch from 208ec26 to 5d2f804 Compare March 5, 2024 16:40
@jabahum jabahum force-pushed the add-auto-update-on-tables branch from 6d7ba9a to 9b5df73 Compare March 6, 2024 17:18
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is getting bigger so we'll make further refactors in follow up PRs

@pirupius pirupius merged commit e31adb9 into openmrs:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants