-
Notifications
You must be signed in to change notification settings - Fork 104
(feat) O3-4750 : Provide support on the form builder to be able to auto create a standard section containing encounterDateTime and encounterProvider to support RDE. #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it possible to translate labels for the two fields
src/config-schema.ts
Outdated
enableRDESection: { | ||
_type: Type.Boolean, | ||
_default: false, | ||
_description: 'Whether to enable the RDE section in the form builder', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_description: 'Whether to enable the RDE section in the form builder', | |
_description: 'Whether to add an Encounter Details section for retrospective data entry, which includes encounter date/time and provider fields', |
I think there's room for improving this config property description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a config for this? Since its just a section to be added into the form, and that too, as it is, gets added to the dummy form which is only if you press the Input dummy schema
button. It doesn't seem like something that a user should need to "configure" to have in a form.
Can't we instead have a checkbox somewhere here that would add the section to the form?
Plus, this way, users could have it anytime and not accessible only under the input dummy schema button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NethmiRodrigo i could explore this approach.
@jabahum if this is following the conversation on Slack here - https://openmrs.slack.com/archives/C04QZ5DDVMG/p1738009752344649?thread_ts=1738007285.263109&cid=C04QZ5DDVMG, if I'm not mistaken, I think the correct way to go about this would be to,
Right @ibacher? |
Yep! A hard-coded "RDE Section" is not something that's going to be sustainable. Each implementation is going to want to control how these fields look, where they occur, etc. So the thing we implement here should be able to handle that, and the most sustainable way to do that is to have the example component form that implementations can then duplicate. |
Requirements
Summary
This PR adds support for RDE on all new generated forms. It adds a new section on the form when
enableRDESection = true
. This section contains two fields encounterDateTime and EncounterProvider.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4750
Other