-
Notifications
You must be signed in to change notification settings - Fork 242
Closed
Labels
PolicySpecific to the Policy APISpecific to the Policy API
Milestone
Description
Is your feature request related to a problem? Please describe.
In the policy README, rule_units
is amount
for a rate rule type, but it could be a unit of time instead if the rate rule has a recurrence of each_time_unit
or per_complete_time_unit
.
Describe the solution you'd like
Get rid of amount
as a valid value for rule_units
. There doesn't seem to be much point in having rule_units
have a value of amount
just for rate rules that recur only once.
Is this a breaking change
I don't think this is breaking. If you write a recurring rate rule, you already have to set rule_units
to some sort of time unit to have the rule make sense in the first place.
- No, not breaking
Impacted Spec
For which spec is this feature being requested?
policy
Describe alternatives you've considered
We could leave it as is, but it seems very confusing to me.
Additional context
Add any other context or screenshots about the feature request here.
Metadata
Metadata
Assignees
Labels
PolicySpecific to the Policy APISpecific to the Policy API