Skip to content

[lworld] Remove redundant DTraceAlloc/Method probes #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 1, 2025

Looking through this code, I found this discrepancy. Tested with some tier1 testing.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1521/head:pull/1521
$ git checkout pull/1521

Update a local copy of the PR:
$ git checkout pull/1521
$ git pull https://git.openjdk.org/valhalla.git pull/1521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1521

View PR using the GUI difftool:
$ git pr show -t 1521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1521.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[lworld] Remove redundant DTraceAlloc/Method probes

Reviewed-by: heidinga

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 67e6bcc: 8360653: [lworld] LayoutIterationTest.java fails with -XX:ForceNonTearable=*

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@coleenp coleenp marked this pull request as ready for review August 1, 2025 15:17
@coleenp coleenp changed the title Remove redundant DTraceAlloc/Method probes [lworld] Remove redundant DTraceAlloc/Method probes Aug 1, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2025

Webrevs

Copy link
Contributor

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@coleenp
Copy link
Contributor Author

coleenp commented Aug 12, 2025

Thanks Dan!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

Going to push as commit 4ce51bf.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 67e6bcc: 8360653: [lworld] LayoutIterationTest.java fails with -XX:ForceNonTearable=*

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2025
@openjdk openjdk bot closed this Aug 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2025
@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@coleenp Pushed as commit 4ce51bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the small branch August 12, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants