-
Notifications
You must be signed in to change notification settings - Fork 89
7904107: AgentOut.othervm.ok should not access $(BUILDTESTDIR)/AgentOut.agentvm #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
|
@vpa1977 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@vpa1977 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@vpa1977 The pull request is being re-evaluated and the inactivity timeout has been reset. |
sormuras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
AgentOut.othervm.ok tries to access $(BUILDTESTDIR)/AgentOut.agentvm. This should only happen in AgentOut.agentvm.ok.
Add a new target to filter log lines that depends on AgentOut.agentvm.ok.
Note: tests pass on retry[1]. The test failure is caused by [2]
[1] https://github.com/vpa1977/jtreg/actions/runs/18863066182
[2] #297
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/299/head:pull/299$ git checkout pull/299Update a local copy of the PR:
$ git checkout pull/299$ git pull https://git.openjdk.org/jtreg.git pull/299/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 299View PR using the GUI difftool:
$ git pr show -t 299Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/299.diff
Using Webrev
Link to Webrev Comment