Skip to content

Conversation

@vpa1977
Copy link

@vpa1977 vpa1977 commented Oct 28, 2025

AgentOut.othervm.ok tries to access $(BUILDTESTDIR)/AgentOut.agentvm. This should only happen in AgentOut.agentvm.ok.
Add a new target to filter log lines that depends on AgentOut.agentvm.ok.

Note: tests pass on retry[1]. The test failure is caused by [2]

[1] https://github.com/vpa1977/jtreg/actions/runs/18863066182
[2] #297


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7904107: AgentOut.othervm.ok should not access $(BUILDTESTDIR)/AgentOut.agentvm (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/299/head:pull/299
$ git checkout pull/299

Update a local copy of the PR:
$ git checkout pull/299
$ git pull https://git.openjdk.org/jtreg.git pull/299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 299

View PR using the GUI difftool:
$ git pr show -t 299

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/299.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7904107: AgentOut.othervm.ok should not access   $(BUILDTESTDIR)/AgentOut.agentvm

Reviewed-by: cstein

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a6a32dd: 7904110: IDEA plugin: Update plugin for new message format
  • da877fc: 7904106: TestNativePath: intermittent test failures due to different test targets using same work dir

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 7904107: AgentOut.othervm.ok should not access $(BUILDTESTDIR)/AgentOut.agentvm 7904107: AgentOut.othervm.ok should not access $(BUILDTESTDIR)/AgentOut.agentvm Oct 28, 2025
@vpa1977 vpa1977 marked this pull request as ready for review October 28, 2025 04:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2025

@vpa1977 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@vpa1977
Copy link
Author

vpa1977 commented Nov 25, 2025

/touch

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@vpa1977 The pull request is being re-evaluated and the inactivity timeout has been reset.

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants