-
Notifications
You must be signed in to change notification settings - Fork 542
8366568: Allow replacing built in application menu in system menu bar #1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back mfox! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
The idea seems interesting. It will need discussion on the mailing list, which I see you've started. /reviewers 2 reviewers |
|
@kevinrushforth |
|
@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request. @beldenfox please create a CSR request for issue JDK-8366568 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
@beldenfox This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
This PR provides an API for replacing the application menu that JavaFX places in the system menu bar on macOS. The application menu is the one next to the Apple menu that is titled with the application's name and contains the Quit menu item. The JavaFX version of this menu has many limitations so this PR allows a developer to simply replace it outright.
Technically there’s no reason to restrict this to only one menu so the API allows the developer to specify an observable list of Menus known as the common system menus. Like the current application menu the common menus are present for all JavaFX windows and remain present even if all windows lose focus. Any per-window menus provided by a MenuBar with useSystemMenuBar set will appear alongside the common system menus.
In addition the PR provides some calls that allow a developer to implement the Hide , Hide Others, and Show All menu items that are expected in the application menu.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1881/head:pull/1881$ git checkout pull/1881Update a local copy of the PR:
$ git checkout pull/1881$ git pull https://git.openjdk.org/jfx.git pull/1881/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1881View PR using the GUI difftool:
$ git pr show -t 1881Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1881.diff
Using Webrev
Link to Webrev Comment