-
Notifications
You must be signed in to change notification settings - Fork 34
8364611: (process) Child process SIGPIPE signal disposition should be default #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Ping @RogerRiggs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
/approval I would like this to be fixed in JDK 25, since it fixes a rare but hard-to-analyze bug around Runtime.exec. |
@tstuefe usage: |
/approval request I would like this to be fixed in JDK 25, since it fixes a rare but hard-to-analyze bug around Runtime.exec. The risk is very small. |
/integrate |
Going to push as commit dd74835.
Your commit was automatically rebased without conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for jdk25
Please backport the follow-up fixes ASAP. Especially https://bugs.openjdk.org/browse/JDK-8365307. AIX build is currently broken! |
Hi all,
Unclean (but trivially merged) backport. We need to address this since we've started seeing it at two customers now, and it makes sense to fix it at least in the upcoming newest LTS.
The backport is unclean since "8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()" is in the way, and @RogerRiggs and I agreed on not backporting that one (had been purposely delayed to miss the JDK25 train).
This pull request contains a backport of commit bdb1646a from the openjdk/jdk repository.
The commit being backported was authored by Thomas Stuefe on 11 Aug 2025 and was reviewed by Erik Joelsson and Roger Riggs.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/86/head:pull/86
$ git checkout pull/86
Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.org/jdk25u.git pull/86/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 86
View PR using the GUI difftool:
$ git pr show -t 86
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/86.diff
Using Webrev
Link to Webrev Comment