Skip to content

8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 8, 2025

Hi all,

This pull request contains a backport of commit 078d0d49 from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 7 Aug 2025 and was reviewed by Daniel D. Daugherty, Johan Sjölen and Axel Boldt-Christmas.

Thanks!


Progress

  • JDK-8364235 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/jdk25u.git pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/75.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 078d0d4968e26bb7a15417f1c4e891869c69dc6c 8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

⚠️ @dholmes-ora This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 8, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 8, 2025
@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2025

Going to push as commit a7cdb53.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2025
@openjdk openjdk bot closed this Aug 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2025
@openjdk
Copy link

openjdk bot commented Aug 17, 2025

@dholmes-ora Pushed as commit a7cdb53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the backport-dholmes-ora-078d0d49-master branch August 17, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant