-
-
Notifications
You must be signed in to change notification settings - Fork 567
Add NetSuite Provider #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetSuite Provider #2362
Conversation
…ase to match all other netsuite responses
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Introspection.cs
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great PR! ❤️
If we can merge it this morning, it will ship as part of the OpenIddict 7.0 release 😃
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Exchange.cs
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
…ationHandlers.Exchange.cs
…ationProviders.xml
…ationProviders.xml
No, that's perfect! 👍🏻
Out of curiosity, does that imply that for confidential clients, they don't use refresh tokens at all and issue access tokens that never expire? |
Thanks for making it so easy to contribute with such good docs.
All access tokens are valid for 60 minutes.
NetSuite is one of those systems that logs you out of the UI constantly and I guess they want to pass that on downstream. |
❤️
🔫 ... yeah, that's really stupid 😄 Merged, thanks a lot for your PR! And congrats for your first contribution to OpenIddict! 🎉 |
This PR adds support for Oracle NetSuite as a provider.
Quirks
expires_in
returned in non-standard string formatid_token
not always returnedat_hash
not constructed correctlyscope
as an array of stringsAfter much poking around I decided a new handler for the introspection response was required. Hopefully that is correct 😎
Other fun notes for future readers
refresh_token
grant only returns an additional refresh token when the client is configured as public in NetSuite and is valid for 3 hours onlytoken
is a refresh token and will not work otherwiseDocs