Fix TODO in RTL. Updated use of priv-lvl signals to match cv32e40s #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oivind Ekelund <[email protected]>
Silabs-ArjanB
requested changes
Sep 7, 2023
rtl/cv32e40x_cs_registers.sv
Outdated
| @@ -1470,7 +1471,12 @@ module cv32e40x_cs_registers import cv32e40x_pkg::*; | |||
| assign mhartid_rdata = mhartid_i; | |||
| assign mconfigptr_rdata = 32'h0; | |||
|
|
|||
| // Only user mode is supported | |||
Signed-off-by: Oivind Ekelund <[email protected]>
rtl/cv32e40x_alignment_buffer.sv
Outdated
| @@ -624,7 +630,32 @@ module cv32e40x_alignment_buffer import cv32e40x_pkg::*; | |||
| assign fetch_ptr_access_o = (ctrl_fsm_i.pc_set && (ctrl_fsm_i.pc_set_clicv || ctrl_fsm_i.pc_set_tbljmp)); | |||
|
|
|||
| // Set privilege level to prefetcher | |||
| assign fetch_priv_lvl_o = PRIV_LVL_M; | |||
| // Privilege level must be updated immediatly to allow the | |||
| // IF stage to do PMP checks with the correct privilege level | |||
There was a problem hiding this comment.
Do we want comments to unimplemented features (PMP)?
There was a problem hiding this comment.
Probably not. Updated the wording.
Signed-off-by: Oivind Ekelund <[email protected]>
silabs-oysteink
approved these changes
Sep 7, 2023
Silabs-ArjanB
approved these changes
Sep 7, 2023
Silabs-ArjanB
added
the
Component:RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEC clean.
instr_priv_lvl_q optimized away during synth.