Remove unused parameter DEBUG_TRIGGER_EN. Add explicit parameter types. #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of fix for openhwgroup#676 Signed-off-by: Oivind Ekelund <[email protected]>
Silabs-ArjanB
requested changes
Apr 3, 2023
bhv/cv32e40x_sim_clock_gate.sv
Outdated
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| module cv32e40x_clock_gate | |||
| #( | |||
| parameter LIB = 0 | |||
| parameter int LIB = 0 | |||
There was a problem hiding this comment.
I don't think we should change the type of LIB
bhv/cv32e40x_wrapper.sv
Outdated
| @@ -50,7 +50,7 @@ | |||
| module cv32e40x_wrapper | |||
| import cv32e40x_pkg::*; | |||
| #( | |||
| parameter LIB = 0, | |||
| parameter int LIB = 0, | |||
rtl/cv32e40x_sleep_unit.sv
Outdated
| @@ -42,7 +42,7 @@ | |||
|
|
|||
| module cv32e40x_sleep_unit import cv32e40x_pkg::*; | |||
| #( | |||
| parameter LIB = 0 | |||
| parameter int LIB = 0 | |||
rtl/cv32e40x_core.sv
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| module cv32e40x_core import cv32e40x_pkg::*; | |||
| #( | |||
| parameter LIB = 0, | |||
| parameter int LIB = 0, | |||
Signed-off-by: Oivind Ekelund <[email protected]>
Silabs-ArjanB
added
the
Component:RTL
Silabs-ArjanB
approved these changes
Apr 3, 2023
Silabs-ArjanB
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #676