Splitting halt_wb to fix timing issues when waking from SLEEP #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmal for all cases except during sleep. During sleep, ctrl_fsm_o.halt_limited_wb will be used to make sure the WB stage does not retire any instructions. Assertions were added to make sure no CSR instruction can be in WB while halt_limited_wb is set. SEC clean. Fixes timing issues. Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
added
the
Component:RTL
Silabs-ArjanB
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split ctrl_fsm_o.halt_wb in two, with ctrl_fsm_o.halt_wb acting as normal for all cases except during sleep. During sleep, ctrl_fsm_o.halt_limited_wb will be used to make sure the WB stage does not retire any instructions.
Assertions were added to make sure no CSR instruction can be in WB while halt_limited_wb is set.
SEC clean.
Fixes timing issues.
Signed-off-by: Oystein Knauserud [email protected]