fix: 7060 - removed preferences v1 #7110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `abstract_user_preferences.dart` * `user_preferences_account.dart` * `user_preferences_advanced_settings.dart` * `user_preferences_choose_accent_color.dart` * `user_preferences_choose_app_theme.dart` * `user_preferences_choose_text_color_contrast.dart` * `user_preferences_connect.dart` * `user_preferences_contribute.dart` * `user_preferences_country_selector.dart` * `user_preferences_currency_selector.dart` * `user_preferences_dev_debug_info.dart` * `user_preferences_donation.dart` * `user_preferences_faq.dart` * `user_preferences_image_source.dart` * `user_preferences_language_selector.dart` * `user_preferences_prices.dart` * `user_preferences_search_page.dart` * `user_preferences_settings.dart` * `user_preferences_search_page.dart` Impacted files: * `app_navigator.dart`: minor refactoring * `bottom_sheets_test.dart`: minor refactoring * `dev_mode_root.dart`: unrelated removal of useless code * `dialogs_test.dart`: minor refactoring * `forgot_password_page-*.png`: golden * `login_page-*.png`: golden * `new_product_header.dart`: minor refactoring * `preferences_page.dart`: minor refactoring * `search_bottom_bar.dart`: minor fix to make tests pass * `search_field.dart`: minor fix to make tests pass * `signup_page-*.png`: golden * `user_preferences_dev_mode.dart`: strongly limited to what's useful * `user_preferences_food.dart`: removed reference to now useless interface AbstractUserPreferences * `user_preferences_page.dart`: now focused only on food * `user_preferences_page-*.png`: golden * `user_preferences_page_test.dart`: minor refactoring
github-project-automation
bot
moved this to 💬 To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7110 +/- ##
============================================
- Coverage 9.54% 4.78% -4.76%
============================================
Files 325 695 +370
Lines 16411 271810 +255399
============================================
+ Hits 1567 13016 +11449
- Misses 14844 258794 +243950 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from 💬 To discuss and validate
to 🎊 Done
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
|
Thank you @g123k for your fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
Deleted files:
abstract_user_preferences.dartuser_preferences_account.dartuser_preferences_advanced_settings.dartuser_preferences_choose_accent_color.dartuser_preferences_choose_app_theme.dartuser_preferences_choose_text_color_contrast.dartuser_preferences_connect.dartuser_preferences_contribute.dartuser_preferences_country_selector.dartuser_preferences_currency_selector.dartuser_preferences_dev_debug_info.dartuser_preferences_donation.dartuser_preferences_faq.dartuser_preferences_image_source.dartuser_preferences_language_selector.dartuser_preferences_prices.dartuser_preferences_search_page.dartuser_preferences_settings.dartuser_preferences_search_page.dartImpacted files:
app_navigator.dart: minor refactoringbottom_sheets_test.dart: minor refactoringdev_mode_root.dart: unrelated removal of useless codedialogs_test.dart: minor refactoringforgot_password_page-*.png: goldenlogin_page-*.png: goldennew_product_header.dart: minor refactoringpreferences_page.dart: minor refactoringsearch_bottom_bar.dart: minor fix to make tests passsearch_field.dart: minor fix to make tests passsignup_page-*.png: goldenuser_preferences_dev_mode.dart: strongly limited to what's usefuluser_preferences_food.dart: removed reference to now useless interface AbstractUserPreferencesuser_preferences_page.dart: now focused only on fooduser_preferences_page-*.png: goldenuser_preferences_page_test.dart: minor refactoring