-
-
Notifications
You must be signed in to change notification settings - Fork 399
feat: Added Robotoff nutrition extraction to nutrition edit page #6366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Robotoff nutrition extraction to nutrition edit page #6366
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6366 +/- ##
==========================================
- Coverage 9.54% 5.84% -3.71%
==========================================
Files 325 490 +165
Lines 16411 29249 +12838
==========================================
+ Hits 1567 1710 +143
- Misses 14844 27539 +12695 ☔ View full report in Codecov by Sentry. |
|
@PrimaelQuemerais Have you tackled the behaviour with no values at all, or some values ? If so can you make another short video of it ? |
|
Here's what it looks like with all fields empty Screen.Recording.2025-02-10.at.11.29.52.AM.mov |
|
@PrimaelQuemerais small conflict to solve |
|
Reworked interface : Screen.Recording.2025-02-15.at.11.38.53.AM.mov |
|
I've added analytics for the number of new suggestions Robotoff is able to find, however I'm not sure how to track the number of accepted suggestions as Is it okay to only track the number of accepted suggestions regardless of the number of suggestions for a specific product? Or do we need to keep count of : accepted / suggested ? |
|
We have various ways to monitor efficiency of nutrition extraction. I'm not sure what @raphael0202 would need from the client if anything. |
|
I changed the analytics to send an event for each nutrient extracted and each insight accepted. |
teolemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A ground breaking change, even if we leave out Matomo for the time being.
|
little merge conflict regarding app_en.arb indentation @PrimaelQuemerais |
What
Users can now get nutrition edit suggestions from Robotoff
After doing some tests with popular products we usually get between 2 and 3 suggestions per product.
Screenshot
Screen.Recording.2025-02-09.at.4.41.37.PM.mov
Part of
#4896