Skip to content

Conversation

@g123k
Copy link
Collaborator

@g123k g123k commented Jan 30, 2025

Hi everyone!

The initial goal of this PR was to show the product type… but as always, there's more than that.
Video: https://github.com/user-attachments/assets/3f66b916-d087-4f91-bb96-b41e4ef92e78

Footer

Visible Product type

Untitled 2

Smaller AppBar on scroll

Untitled 2

Body

The huge barcode is removed 🎉

Footer

A button provides access to multiple actions (in the future: it would be nice to be able to flag an incorrect type or to view data quality tags)

Button or swipe gesture

Untitled 2

Barcode viewer

IMG_2090

Misc

This PR adds some icons for the License screen

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 3.20700% with 332 lines in your changes missing coverage. Please review.

Project coverage is 5.95%. Comparing base (4d9c7fc) to head (351a329).
Report is 715 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/smooth_app/lib/widgets/v2/smooth_topbar2.dart 0.00% 81 Missing ⚠️
...ages/product/edit_product/edit_product_footer.dart 1.36% 72 Missing ⚠️
...roduct/product_page/footer/new_product_footer.dart 2.08% 47 Missing ⚠️
...roduct_page/footer/new_product_footer_barcode.dart 2.85% 34 Missing ⚠️
...es/smooth_app/lib/widgets/v2/smooth_scaffold2.dart 0.00% 22 Missing ⚠️
packages/smooth_app/lib/resources/app_icons.dart 19.04% 17 Missing ⚠️
...oduct_page/footer/new_product_footer_settings.dart 0.00% 16 Missing ⚠️
.../pages/product/edit_product/edit_product_page.dart 0.00% 13 Missing ⚠️
...t_page/footer/new_product_footer_open_website.dart 9.09% 10 Missing ⚠️
...ter/new_product_footer_data_contributor_guide.dart 12.50% 7 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6313      +/-   ##
==========================================
- Coverage     9.54%   5.95%   -3.60%     
==========================================
  Files          325     477     +152     
  Lines        16411   28152   +11741     
==========================================
+ Hits          1567    1676     +109     
- Misses       14844   26476   +11632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 61585ca into openfoodfacts:develop Jan 30, 2025
6 checks passed
@g123k g123k deleted the edit_product_page_footer_product_type branch January 30, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants