Skip to content

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Oct 10, 2025

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated documentation link-checking configuration in CI to broaden accepted responses, reducing false positives during automated link validation.
    • Improves reliability of documentation checks in pull requests and scheduled runs, helping prevent unnecessary failures while still catching genuinely broken links.
    • Ensures smoother contributor experience and more consistent build outcomes; no user-facing functionality is affected.

@rhamzeh rhamzeh requested review from a team as code owners October 10, 2025 16:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The GitHub workflow configuration for the markdown links checker was updated to add HTTP status code 0 to the aliveStatusCodes array, changing it from [200, 206, 403] to [0, 200, 206, 403]. No other files or logic were modified.

Changes

Cohort / File(s) Summary
CI config
\.github/workflows/markdown.links.config.json
Add status code 0 to aliveStatusCodes, expanding from [200, 206, 403] to [0, 200, 206, 403].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title addresses fixing CI issues that cause markdown lint failures, which aligns with the change to adjust the lint configuration to accept status code 0; it clearly indicates the CI chore and the markdown lint context, though it does not call out the specific code adjustment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-14 15:53 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d0b80e and 5aa2a8a.

📒 Files selected for processing (1)
  • .github/workflows/markdown.links.config.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: deploy-preview
  • GitHub Check: Run Checks
  • GitHub Check: Test deployment

@rhamzeh rhamzeh requested review from a team as code owners October 10, 2025 17:14
@rhamzeh rhamzeh changed the title chore(ci): make markdown lint treat status code 0 as a success chore(ci): fix issues causing markdown lint to fail Oct 10, 2025
@rhamzeh rhamzeh enabled auto-merge (squash) October 10, 2025 20:32
@rhamzeh rhamzeh merged commit c9a1ba5 into main Oct 14, 2025
17 checks passed
@rhamzeh rhamzeh deleted the chore/ci-fix-failing-md-lint branch October 14, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants