A new thread is being created for every OpenFgaClient call

[Jacksongoulart]

Description

A new HttpClient is being created for each request, leading to an increasing number of threads. Specifying a thread pool alleviates the problem, but not completely. The issue happens because here a new HttpClient is built everytime.

Version of SDK

v0.3.1

Reproduction

Below is an example of how to reproduce the issue.

1. Initialize OpenFgaClient with any set of configs;
2. Invoke method OpenFgaClient#write(ClientWriteRequest request) multiple times;
3. Notice that for every write call, a new thread is created. If you have 300k write calls, 300k threads are created, eventually running out of memory.

Expected behavior

It should not create a new thread for every request.

[paulosuzart]

Just to add: In the meantime, a workaround was:

        var apiClient = new ApiClient()
                .setHttpClientBuilder(HttpClient.newBuilder()
                        .executor(Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors())));
        return new OpenFgaClient(config, apiClient);

This way, we control the pool to be used by the N HttpClients.

[jimmyjames]

Thanks for reporting, you are correct; we should not create a new http client for each request.

[rhamzeh]

Thanks for the keen eye @Jacksongoulart 🕵🏽

The fix is now out in v0.3.2