-
Notifications
You must be signed in to change notification settings - Fork 15
release: v0.7.0 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.7.0 #129
Conversation
WalkthroughUpdates documentation to reflect new framework targets and support policy, adds a new SUPPORTED_FRAMEWORKS.md, and updates CHANGELOG for v0.7.0. Bumps package version to 0.7.0 and updates the default User-Agent and public Version constant in Configuration.cs. No functional code changes beyond metadata/version strings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b14d0c5 to
61223cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (1)
94-103: Helpful framework support documentation added.The new "Supported Frameworks" section provides clear guidance on supported targets and the support policy. The reference to SUPPORTED_FRAMEWORKS.md for detailed information is appropriate.
Minor: Markdown lint issue on line 99.
The bare URL should be wrapped in angle brackets to comply with markdown best practices:
-https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core +<https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core>SUPPORTED_FRAMEWORKS.md (1)
15-15: Minor: Markdown lint issue on line 15.The bare URL should be wrapped in angle brackets to comply with markdown best practices:
-https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core +<https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)README.md(2 hunks)SUPPORTED_FRAMEWORKS.md(1 hunks)src/OpenFga.Sdk/Configuration/Configuration.cs(1 hunks)src/OpenFga.Sdk/OpenFga.Sdk.csproj(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
99-99: Bare URL used
(MD034, no-bare-urls)
SUPPORTED_FRAMEWORKS.md
15-15: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Analyze (csharp)
- GitHub Check: Test netcoreapp3.1 on windows-latest
- GitHub Check: Test net48 on windows-latest
- GitHub Check: Test net8.0 on windows-latest
🔇 Additional comments (5)
src/OpenFga.Sdk/OpenFga.Sdk.csproj (1)
16-16: Version bump looks good.The package version update to 0.7.0 is consistent with the changes in Configuration.cs and aligns with the CHANGELOG entry.
CHANGELOG.md (1)
5-28: Well-documented release notes.The v0.7.0 changelog entry clearly describes the framework support changes and provides a comprehensive migration guide for the breaking changes. The detailed tables for renamed models and enum values will be helpful for users upgrading.
src/OpenFga.Sdk/Configuration/Configuration.cs (1)
78-80: Version constants updated correctly.Both the public Version constant and the DefaultUserAgent string are now consistent with the package version bump to 0.7.0.
SUPPORTED_FRAMEWORKS.md (2)
1-85: Excellent framework support documentation.This comprehensive documentation provides clear guidance on:
- Supported framework targets and their rationale
- Support policy aligned with Microsoft's lifecycle
- CI/test coverage matrix
- Target addition/removal criteria
- Troubleshooting guidance and FAQ
The structure and content will help users understand the framework support strategy and make informed decisions.
27-27: Confirmed workflow file reference is correct The file.github/workflows/main.yamlexists; no updates needed.
Description
Warning
BREAKING CHANGES:
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
Documentation
Chores