Skip to content

Conversation

5k4nd
Copy link
Contributor

@5k4nd 5k4nd commented Jun 18, 2025

Upgrade from 7.x to 8.x targeting the latest 8x release 8.18.2.

Changes

The main difference lies in the reduction phase for multi-bucket aggregations, which has significantly changed internally on the Elasticsearch side.

In version 7.x, the reduce() method would take a list of InternalMultiBucketAggregation instances and merge them into a single aggregated result.

In version 8.x, the process is now split into three distinct phases:

  1. Accumulation phase using accept(...): collects all buckets, shard by shard.
  2. Finalization phase using get(): combines, sorts, and applies limits.
  3. Cleanup phase using close(): handles memory cleanup.

License change

To align with Elasticsearch’s license evolution, starting with this release (8.18.2.0), this plugin is now licensed under the AGPLv3.

@5k4nd 5k4nd force-pushed the 8.18 branch 2 times, most recently from c0657d0 to f0654c6 Compare June 18, 2025 09:57
@5k4nd 5k4nd changed the title (WiP) 8.18 upgrade 8.18 upgrade Jun 18, 2025
@5k4nd 5k4nd requested a review from garaud June 18, 2025 09:58
Copy link

@garaud garaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I just left some comments.

@@ -1,2 +1,4 @@
es_version = 7.17.28
plugin_version = 7.17.28.0
#es_version = 7.17.28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the comment about the Elastic previous version.

@@ -1,62 +1,62 @@
package com.opendatasoft.elasticsearch.search.aggregations.bucket.geopointclustering;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this file can be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants