-
Notifications
You must be signed in to change notification settings - Fork 16
8.18 upgrade #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8.18 upgrade #18
Conversation
c0657d0
to
f0654c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I just left some comments.
gradle.properties
Outdated
@@ -1,2 +1,4 @@ | |||
es_version = 7.17.28 | |||
plugin_version = 7.17.28.0 | |||
#es_version = 7.17.28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the comment about the Elastic previous version.
@@ -1,62 +1,62 @@ | |||
package com.opendatasoft.elasticsearch.search.aggregations.bucket.geopointclustering; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this file can be deleted
Upgrade from 7.x to 8.x targeting the latest 8x release 8.18.2.
Changes
The main difference lies in the reduction phase for multi-bucket aggregations, which has significantly changed internally on the Elasticsearch side.
In version 7.x, the reduce() method would take a list of InternalMultiBucketAggregation instances and merge them into a single aggregated result.
In version 8.x, the process is now split into three distinct phases:
License change
To align with Elasticsearch’s license evolution, starting with this release (8.18.2.0), this plugin is now licensed under the AGPLv3.