Add protofbuf dependency for s390x

[nikheal2]

Description

Build fails with protobuf greater than 6.32.1 on s390x platform.

And for runtime , it segfaults.
This change will install protobuf==6.32.1 for s390x platform

For runtime:

$ python -m vllm_tgis_adapter --model ibm-ai-platform/micro-g3.3-8b-instruct-1b --max_model_len=64 --max-num-seqs=4 --tensor-parallel-size=2 

INFO 11-22 14:54:46 [__init__.py:36] Available plugins for group vllm.platform_plugins:
INFO 11-22 14:54:46 [__init__.py:38] - spyre -> vllm_spyre:register
INFO 11-22 14:54:46 [__init__.py:48] Loading plugin spyre
INFO 11-22 14:54:46 [__init__.py:207] Platform plugin spyre is activated
WARNING:torchao.kernel.intmm:warning: Detected no triton, on systems without Triton certain kernels will not work
Segmentation fault (core dumped)

For buildtime :

Using Python 3.12.11 environment at: /root/rhaiis/tgis-venv
Resolved 122 packages in 316ms
Uninstalled 1 package in 0.53ms
Installed 1 package in 1ms
  × Failed to build vllm-tgis-adapter @ file:///root/rhaiis/vllm-tgis-adapter
  ├─▶ The build backend returned an error
  ╰─▶ Call to setuptools.build_meta.build_wheel failed (exit status: 1)

      [stdout]
      running bdist_wheel
      running build
      running build_py
      Invoking protoc on vllm_tgis_adapter/grpc/pb/generation.proto

      [stderr]
      /root/rhaiis/tgis-venv/lib64/python3.12/site-packages/setuptools/config/_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning:
      project.license as a TOML table is deprecated
      !!

              ********************************************************************************
              Please use a simple string containing a SPDX expression for project.license. You can also use project.license-files.
      (Both options available on setuptools>=77.0.0).

              By 2026-Feb-18, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
              ********************************************************************************

      !!
        corresp(dist, value, root_dir)
      --mypy_out: protoc-gen-mypy: Plugin killed by signal 11.
      error: protoc failed, exit code 1

  hint: This usually indicates a problem with the package or the build environment.

[coderabbitai]

Walkthrough

A platform-specific protobuf dependency constraint is added to pyproject.toml for s390x architecture systems. The dependency protobuf==6.32.1; platform_machine == 's390x' is introduced in both build-system requires and dependencies sections.

Changes

Cohort / File(s)	Change Summary
Platform-specific protobuf dependency pyproject.toml	Adds conditional protobuf==6.32.1 dependency scoped to s390x architecture in both build-system requires and project dependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• This is a straightforward dependency constraint addition with minimal risk
• Verify that the protobuf version and platform condition syntax are correct for the build tool in use

Poem

🐰 A platform born of ancient lore,
Now s390x gets protobuf store!
Dependencies bound by machine's own call,
This tiny change unites them all! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title contains a typo ('protofbuf' instead of 'protobuf') and is otherwise concise and directly related to the main change: adding a protobuf dependency for s390x platform.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

pyproject.toml (1)

7-7: Consider adding a fallback protobuf version for non-s390x platforms.

The duplication of the protobuf constraint across build-system requires and project dependencies may be intentional (one for build-time code generation, one for runtime). However, consider whether a default/fallback protobuf version should be specified for non-s390x platforms to ensure consistent builds and runtime behavior. Currently, non-s390x platforms will receive whatever version grpcio-tools transitively depends on, which may differ from development and testing assumptions.

Also applies to: 38-38

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0d5363 and 2b48c7e.

📒 Files selected for processing (1)

• pyproject.toml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: tests (ubuntu-latest, 3.12, v0.10.0)
• GitHub Check: tests (ubuntu-latest, 3.12, v0.11.0)
• GitHub Check: tests (ubuntu-latest, 3.12, v0.10.2)
• GitHub Check: tests (ubuntu-latest, 3.12, v0.10.1.1)

🔇 Additional comments (1)

pyproject.toml (1)

7-7: The original review comment's concerns are not substantiated.

Verification confirms that grpcio-tools==1.75.1 explicitly requires protobuf<7.0.0,>=6.31.1, so the protobuf==6.32.1 constraint falls safely within this range. On non-s390x platforms, grpcio-tools will pull a compatible protobuf version from its transitive dependency—there is no risk of version conflicts or inconsistent behavior. The environment marker syntax is valid and correct.

Likely an incorrect or invalid review comment.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.51%. Comparing base (a0d5363) to head (2b48c7e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   64.51%   64.51%           
=======================================
  Files          25       25           
  Lines        1660     1660           
  Branches      213      213           
=======================================
  Hits         1071     1071           
  Misses        487      487           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.