validation: add mount validation #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by missing @q384566678 |
zhouhao3
force-pushed
the
validation-mount
branch
from
a0fd674 to
3109ca3
Compare
|
Fixed. |
|
LGTM |
wking
reviewed
Dec 29, 2017
validation/mounts.go
Outdated
| "nosuid", | ||
| "strictatime", | ||
| "mode=755", | ||
| "size=65536k", |
There was a problem hiding this comment.
I'm not sure if mounting the tmpfs actually allocates the memory or not, but since this is just a test and we aren't writing anything to /tmp I'd rather use a smaller value (1k?). On the other hand, 65 MB isn't that big.
|
@mrunalp @Mashimiao PTAL |
Signed-off-by: Zhou Hao <[email protected]>
zhouhao3
force-pushed
the
validation-mount
branch
from
3109ca3 to
c2f774c
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhou Hao [email protected]