Skip to content

Conversation

TroyWarez
Copy link
Contributor

OB Description

(Copy of main pull request to dev branch)
This pull request is in response to these ongoing issues:

#138

#139

The first change is to the list_settings function in data.py, that adds new conditions to filter out the AWS secrets from being exported to the config file.
The second change sets the admin username to the provided username from the configuration page. This fixes the stale username from being used by the authentication system when the Admin password and username is changed.

The last changes are related to code formatting and fixing a typo in the index.html file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Yes, I ran the obplayer software twice and the issue of AWS secrets being in the config file were not present. You can also change the Admin username and password in one seamlessly process now. I was also able to change my Admin username and password at once with a working login shortly after the change.

Testing Environments

OpenBroadcaster Component and Version

  • OBServer
  • OBPlayer
  • Module
  • Other

Browser Version?

  • Chrome
  • Edge 141.0.0.0 (Official build) (64-bit)
  • Firefox
  • Safari
  • Other

OS Version?

  • BSD
  • Debian
  • Raspberry OS
  • Ubuntu 24.04.1 (LTS)
  • Other

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thanks for contributing!

@radiorob radiorob requested a review from brookgagnon October 9, 2025 18:17
@brookgagnon brookgagnon merged commit 30c940f into openbroadcaster:5.3-develop Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants