5.3 develop bug fixes #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OB Description
(Copy of main pull request to dev branch)
This pull request is in response to these ongoing issues:
#138
#139
The first change is to the
list_settings
function indata.py
, that adds new conditions to filter out the AWS secrets from being exported to the config file.The second change sets the admin username to the provided username from the configuration page. This fixes the stale username from being used by the authentication system when the Admin password and username is changed.
The last changes are related to code formatting and fixing a typo in the index.html file.
Type of change
How Has This Been Tested?
Yes, I ran the obplayer software twice and the issue of AWS secrets being in the config file were not present. You can also change the Admin username and password in one seamlessly process now. I was also able to change my Admin username and password at once with a working login shortly after the change.
Testing Environments
OpenBroadcaster Component and Version
Browser Version?
OS Version?
Checklist:
Thanks for contributing!