Fix bool types #437
Merged
Fix bool types #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
requested review from
ShivangiReja,
joseharriaga and
trrwilson
as code owners
|
Any feedback? |
jsquire
approved these changes
Jun 22, 2025
There was a problem hiding this comment.
Hi @shargon. Thank you for your contribution and interest in improving the OpenAI developer experience. This change looks to be correct to me. I was going to mention that it would be good to validate with a test, but it looks like coverage here is missing entirely rather than just for this scenario.
@joseharriaga: This looks to be a clean fix that is safe to make here. Can you please confirm and, if so, complete the merge?
|
Confirmed with @joseharriaga that this does not conflict with any upstream work and is safe to merge once tests pass. |
jsquire
added
the
live test
|
Failures are unrelated to these changes and indicate an issue in the live testing environment. Merging based on units passing. |
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cswr.github.io/JsonSchema/spec/basic_types/