chore(ci): Speed up macOS builds by using larger runner #5234
Conversation
JaviSoto
force-pushed
the
dev/javi/release-workflow-manually
branch
from
36cd3fa to
ebfa879
Compare
JaviSoto
changed the base branch from
dev/javi/release-workflow-manually
to
main
JaviSoto
force-pushed
the
dev/javi/faster-builds
branch
from
64fdc74 to
5810975
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
codex/.github/workflows/rust-release.yml
Lines 103 to 105 in 5810975
macOS signing steps no longer run after runner rename
The matrix now schedules mac builds on macos-15-xlarge, but the downstream steps for configuring code signing, signing, notarization, and keychain cleanup still check matrix.runner == 'macos-14'. Because that condition is never true anymore, none of the signing/notarization steps execute and macOS release artifacts will be unsigned and unnotarized. Update the condition (and the related ones later in the job) to match the new runner label or to detect macOS runners more generally so the signing process continues to run.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - runner: macos-15-xlarge | ||
| target: aarch64-apple-darwin | ||
| - runner: macos-14 | ||
| - runner: macos-15-xlarge |
There was a problem hiding this comment.
We will also need to update the runner checks below (i.e. code sign step) from macos-14 to macos-15-xlarge too.
3 participants
Saves about 2min per build
https://github.com/openai/codex/actions/runs/18544852356/job/52860637804 vs
https://github.com/openai/codex/actions/runs/18545106208/job/52861427485