-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat(config): add review_model support to profile and TUI #5220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@codex given that these changes were neither written nor reviewed by GPT5 (due to an unfortunate run in with a weekly rate limit last weekend!) I ask you to: 1. Perform a full review of all changes and write a robust PR desc in a comment below, and 2. Perform a meticulous critical review of this PR, and highlight every and any thing I should or could have done better - every nitpick - don’t hold back. |
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Note To use Codex here, create an environment for this repo. |
1 similar comment
Note To use Codex here, create an environment for this repo. |
@codex Conduct an exhaustive, evidence-based critical review of every single assumption made, against primary source documentation. Verify similarly against any project documentation and highlight any inconcruencies or inaccuracies. Do not assume any previous step was correct; re-verify everything from scratch. It is possible your initial analysis was flawed and a rigorous verification process is essential. |
Note To use Codex here, create an environment for this repo. |
@dedrisian-oai politely requesting your review, it seems like reviewing reviews is your area! |
/review
appears hardcoded to always usegpt-5-codex
despite customizingmodel
configuration.While
review_model
could be set globally inconfig.toml
or via theOPENAI_DEFAULT_REVIEW_MODEL
env var, this was undocumented and really only partially implemented.It was confounding to users who had configured
model
(#4558, #4788):/review
was non-functional (400 Bad Request: could not find real modelID for gpt-5-codex
) with no clear or convenient solution available. Furthermore, users who don’t configuremodel
may still wish to perform code reviews using alternative OpenAI models (such asgpt-5-pro
orcodex-mini-latest
).This PR finishes off the implementation of
review_model
to be fully-fledged and well documented, following existing patterns to function much like its sibling,model
.review_model
has been added to profile scope (ConfigProfile
struct) as well as TUI (--review-model
). Documentation indocs/config.md
and--help
has been updated to reflect its availability, as have tests.