Skip to content

Conversation

kierr
Copy link

@kierr kierr commented Oct 15, 2025

/review appears hardcoded to always use gpt-5-codex despite customizing model configuration.

While review_model could be set globally in config.toml or via the OPENAI_DEFAULT_REVIEW_MODEL env var, this was undocumented and really only partially implemented.

It was confounding to users who had configured model (#4558, #4788): /review was non-functional (400 Bad Request: could not find real modelID for gpt-5-codex) with no clear or convenient solution available. Furthermore, users who don’t configure model may still wish to perform code reviews using alternative OpenAI models (such as gpt-5-pro or codex-mini-latest).

This PR finishes off the implementation of review_model to be fully-fledged and well documented, following existing patterns to function much like its sibling, model.

review_model has been added to profile scope (ConfigProfile struct) as well as TUI (--review-model). Documentation in docs/config.md and --help has been updated to reflect its availability, as have tests.

Copy link

github-actions bot commented Oct 15, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kierr
Copy link
Author

kierr commented Oct 15, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 15, 2025
@kierr
Copy link
Author

kierr commented Oct 15, 2025

@codex given that these changes were neither written nor reviewed by GPT5 (due to an unfortunate run in with a weekly rate limit last weekend!) I ask you to: 1. Perform a full review of all changes and write a robust PR desc in a comment below, and 2. Perform a meticulous critical review of this PR, and highlight every and any thing I should or could have done better - every nitpick - don’t hold back.

Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Copy link
Contributor

Note

To use Codex here, create an environment for this repo.

1 similar comment
Copy link
Contributor

Note

To use Codex here, create an environment for this repo.

@kierr kierr marked this pull request as ready for review October 15, 2025 19:03
@kierr
Copy link
Author

kierr commented Oct 15, 2025

@codex Conduct an exhaustive, evidence-based critical review of every single assumption made, against primary source documentation. Verify similarly against any project documentation and highlight any inconcruencies or inaccuracies. Do not assume any previous step was correct; re-verify everything from scratch. It is possible your initial analysis was flawed and a rigorous verification process is essential.

Copy link
Contributor

Note

To use Codex here, create an environment for this repo.

@kierr
Copy link
Author

kierr commented Oct 15, 2025

@dedrisian-oai politely requesting your review, it seems like reviewing reviews is your area!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant