Skip to content

Conversation

jcronenberg
Copy link
Member

Description

This PR sets the relevant NM config options that are required so the DHCPv4 client identifier is the same between wicked and NM. I haven't tested DHCPv6 yet.

What's required to set is

ipv4.dhcp-client-id=ipv6-duid
ipv6.dhcp-duid=llt
ipv4.dhcp-iaid=mac

Screenshots

wicked:
image
NM without changes:
image
NM with changes:
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17768932103

Details

  • 9 of 17 (52.94%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 49.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/interface.rs 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
src/interface.rs 1 69.93%
src/reader.rs 1 25.29%
src/wireless.rs 1 47.57%
Totals Coverage Status
Change from base Build 16935531844: 0.06%
Covered Lines: 454
Relevant Lines: 909

💛 - Coveralls

@cfconrad
Copy link
Collaborator

As a general comment to this topic, we are not getting the similar CID, because how the CID is created (even if we will have the same DUID Type) can be different.
E.g.
I have a setup with 2 interfaces. I run DHCPv6 only on the second one.
But the DUID, which wicked is using, was created with the HWAddr of the first on. Compared to NetworkManager, the DUID is created with the HWaddr of the interface it self.
I think it would be nice, if we mention a way how to set the DUID directly using ipv6.dhcp-duid and ipv4.dhcp-client-id explicit with the value from wicked duid.

@jcronenberg jcronenberg changed the title Apply dhcp4 settings to mirror wicked client id Apply dhcp settings to mirror wicked client id Sep 18, 2025
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@cfconrad cfconrad merged commit 3446bd2 into openSUSE:master Sep 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants