change how to set params type to new token in set_package #15489
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15489 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 789 789
Lines 25832 25833 +1
=======================================
+ Hits 22281 22282 +1
Misses 3551 3551 |
|
@FiloSpaTeam thanks for your contribution! I will have a look on the changes |
|
@FiloSpaTeam Hey, I had a look. The changes looking good to me, took me a bit to understand the issue itself. Could you do me a favor and just add the reasoning for the changes (basically what you wrote in the PR description) into the commit message as well. Always good to have it tracked in Git itself. And maybe remove the the issue number from the commit title and just mention it in the description. Thanks! |
No problem. I ll do tomorrow morning :) |
FiloSpaTeam
changed the title
Using the method `Token.token_type` for set instance var `@token` after a wrongly search on package name or project name, will change the class type of the @token, that set up a wrong `form_with` that returns a wrong params name after submit. So i changed the method above with `write_attribute` to set the type.
2 participants
Hey Friends (yikes! like the CONTRIBUTING.md :) )
actually fixed this one #15403;
What's wrong with the old code?
Using the method
Token.token_type, the class itself changes and theform_with(@token)use the new form class to name the params, so therequire(:token)will throw an error.But the problems is not always available. You need to make a wrong search on project name or package name.
So setting the type with the
write_attribute(:type)and removing thetoken_typeallow to set the :type back and render correctly the :new partial.The fix correlated regards the default value for the
:typein theradio_buttons, was hard typed withservice.