Skip to content

Implement semantic-release and conventional commits #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2017

Conversation

jlegrone
Copy link
Contributor

@jlegrone jlegrone commented Aug 4, 2017

No description provided.

@jlegrone jlegrone requested a review from alexdiliberto August 4, 2017 20:35
@jlegrone jlegrone force-pushed the feature/semantic-release branch 4 times, most recently from 3116d3f to a939515 Compare August 4, 2017 20:52
alexdiliberto
alexdiliberto previously approved these changes Aug 4, 2017
Copy link
Contributor

@alexdiliberto alexdiliberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,6 +2,9 @@
[![Build Status](https://travis-ci.org/open-tux/ember-bulma.svg?branch=master)](https://travis-ci.org/open-tux/ember-bulma)
[![Ember Observer Score](http://emberobserver.com/badges/ember-bulma.svg)](https://emberobserver.com/addons/ember-bulma)

[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlegrone 👍 Commitizen, awesome

name: 'revert: Revert to a commit'
}
];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlegrone I'm good with this for now, we may want something like style as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added style and perf 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any default scopes you think would be useful?

Copy link
Contributor

@alexdiliberto alexdiliberto Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlegrone yea scopes are a definitely the trickier bit to standardize IMO. I lean to something like the default ember resolver for example: component:date-picker, route:users, service:auth but that only works for isolated updates and is a bit long for word count. Then for broader stuff like ci, scss, etc. it's harder unless enforcing strictly atomic commits without exception

@jlegrone
Copy link
Contributor Author

jlegrone commented Aug 7, 2017

I'd like to get Travis set up to run semantic-release before merging. @alexdiliberto or someone else with publish permissions, can you switch to this feature branch and follow these instructions? If you end up with a local diff please feel free to push those changes and I can squash them in.

https://github.com/semantic-release/semantic-release#setup

alexdiliberto
alexdiliberto previously approved these changes Aug 7, 2017
name: 'revert: Revert to a commit'
}
];

Copy link
Contributor

@alexdiliberto alexdiliberto Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlegrone yea scopes are a definitely the trickier bit to standardize IMO. I lean to something like the default ember resolver for example: component:date-picker, route:users, service:auth but that only works for isolated updates and is a bit long for word count. Then for broader stuff like ci, scss, etc. it's harder unless enforcing strictly atomic commits without exception

@alexdiliberto
Copy link
Contributor

alexdiliberto commented Aug 7, 2017

@jlegrone @jbailey4 You have both been added as collaborators via NPM for publish permissions

Copy link
Contributor

@alexdiliberto alexdiliberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, Merge away

@jlegrone jlegrone merged commit 3d01335 into master Aug 7, 2017
@jlegrone jlegrone deleted the feature/semantic-release branch August 7, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants