-
Notifications
You must be signed in to change notification settings - Fork 14
Implement semantic-release and conventional commits #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3116d3f
to
a939515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,6 +2,9 @@ | |||
[](https://travis-ci.org/open-tux/ember-bulma) | |||
[](https://emberobserver.com/addons/ember-bulma) | |||
|
|||
[](http://commitizen.github.io/cz-cli/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlegrone 👍 Commitizen, awesome
name: 'revert: Revert to a commit' | ||
} | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlegrone I'm good with this for now, we may want something like style
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added style and perf 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any default scopes you think would be useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlegrone yea scopes are a definitely the trickier bit to standardize IMO. I lean to something like the default ember resolver for example: component:date-picker
, route:users
, service:auth
but that only works for isolated updates and is a bit long for word count. Then for broader stuff like ci
, scss
, etc. it's harder unless enforcing strictly atomic commits without exception
18dc5c0
to
8788435
Compare
I'd like to get Travis set up to run semantic-release before merging. @alexdiliberto or someone else with publish permissions, can you switch to this feature branch and follow these instructions? If you end up with a local diff please feel free to push those changes and I can squash them in. https://github.com/semantic-release/semantic-release#setup |
name: 'revert: Revert to a commit' | ||
} | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlegrone yea scopes are a definitely the trickier bit to standardize IMO. I lean to something like the default ember resolver for example: component:date-picker
, route:users
, service:auth
but that only works for isolated updates and is a bit long for word count. Then for broader stuff like ci
, scss
, etc. it's harder unless enforcing strictly atomic commits without exception
8788435
to
6189c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, Merge away
No description provided.