Stabilize Logger.Enabled #4463
Merged
Stabilize Logger.Enabled #4463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
added
spec:logs
jack-berg
approved these changes
Mar 27, 2025
MrAlias
approved these changes
Mar 27, 2025
reyang
approved these changes
Mar 27, 2025
lmolkova
approved these changes
Mar 27, 2025
jsuereth
approved these changes
Mar 28, 2025
Merged
carlosalberto
added a commit
that referenced
this pull request
Apr 15, 2025
### Context - Add context propagation through Environment Variables specification. ([#4454](#4454)) - On Propagators API, stabilize `GetAll` on the `TextMap` Extract. ([#4472](#4472)) ### Traces - Define sampling threshold field in OpenTelemetry TraceState; define the behavior of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2 randomness. ([#4166](#4166)) ### Metrics - Clarify SDK behavior for Instrument Advisory Parameter. ([#4389](#4389)) ### Logs - Add `Enabled` opt-in operation to the `LogRecordProcessor`. ([#4439](#4439)) - Stabilize `Logger.Enabled`. ([#4463](#4463)) - Stabilize `EventName`. ([#4475](#4475)) ### Baggage - Add context (baggage) propagation through Environment Variables specification. ([#4454](#4454)) ### Resource - Add Datamodel for Entities. ([#4442](#4442)) ### SDK Configuration - Convert declarative config env var substitution syntax to ABNF. ([#4448](#4448)) - List declarative config supported SDK extension plugin interfaces. ([#4452](#4452)) --------- Co-authored-by: Armin Ruech <[email protected]>
This was referenced May 27, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
Fixes #4397 Towards #4463 Content is based on https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#enabled. --------- Co-authored-by: Carlos Alberto Cortez <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
This part of the specification can be stabilized. It primarily defines how the SDK should respond to `Logger.Enabled` calls. I believe adding new rules in this context should not be considered breaking changes. Notice that `Logger.Enabled` API has been already stabilized in #4463. --------- Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4208
Current state of implementations:
CC @jack-berg, @cijothomas, @brettmc