Skip to content

Clarify that logs attributes are a superset of standard attributes #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 27, 2024
Merged

Clarify that logs attributes are a superset of standard attributes #3852

merged 22 commits into from
Feb 27, 2024

Conversation

@pellared
Copy link
Member

@pellared pellared commented Jan 31, 2024 •
edited
Loading

Fixes #3849

Related PR: #3827

Changes

  • Clarify that logs attributes are a superset of standard attributes
  • Remove SHOULD follow OpenTelemetry semantic conventions for attributes because:
    • It should be a recommendation for API users (probably for semantic convention for Events?)
    • It does not make really sense for Bridge API users
  • Editorial change: other than TraceId/SpanId) -> other than Trace Context Fields

@pellared pellared marked this pull request as ready for review January 31, 2024 10:34
@pellared pellared requested review from a team January 31, 2024 10:34
@pellared
Copy link
Member Author

pellared commented Jan 31, 2024

@tedsuo @trask PTAL

MrAlias
MrAlias reviewed Jan 31, 2024
View reviewed changes
@pellared pellared requested a review from MrAlias January 31, 2024 18:45
@pellared pellared changed the title Clarify that logs attributes are a superset of common attributes Clarify that logs attributes are a superset of attributes Jan 31, 2024
pellared
pellared commented Jan 31, 2024
View reviewed changes
@jack-berg
Copy link
Member

jack-berg commented Jan 31, 2024

FYI, I just opened #3858 partially mindful of this PR. It codifies that attributes can't evolve to include complex types, and calls out log attributes as a special case so that it doesn't appear as an accident or oversight.

@pellared pellared changed the title Clarify that logs attributes are a superset of attributes Clarify that logs attributes are a superset of standard attributes Jan 31, 2024
arminru
arminru reviewed Feb 5, 2024
View reviewed changes
@pellared pellared mentioned this pull request Feb 6, 2024
Merged
trask
trask approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems uncontroversial

@arminru arminru merged commit 8a78903 into open-telemetry:main Feb 27, 2024
jaydeluca pushed a commit to jaydeluca/opentelemetry-specification that referenced this pull request Feb 29, 2024
@pellared @jaydeluca
Clarify that logs attributes are a superset of standard attributes (o…
8fb13cf 
…pen-telemetry#3852)
@pellared pellared deleted the log-attrs-are-not-common branch July 15, 2024 19:47
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@pellared
Clarify that logs attributes are a superset of standard attributes (o…
60cf890 
…pen-telemetry#3852)
@pellared pellared mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrAlias MrAlias MrAlias approved these changes

@trask trask trask approved these changes

@arminru arminru arminru approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@arminru arminru

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify that log attributes are NOT standard attributes

5 participants

@pellared @jack-berg @trask @MrAlias @arminru