Skip to content

Conversation

@bantonsson
Copy link
Contributor

@bantonsson bantonsson commented Nov 5, 2025

Fixes #3190

Changes

Removes the dependency on tracing-opentelemetry to get rid of the circular dependencies.

  • Remove the experimental_use_tracing_span_context since
    tracing-opentelemetry now supports activating the OpenTelemetry
    context for the current tracing span.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson requested a review from a team as a code owner November 5, 2025 15:34
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (cff5728) to head (3b70f41).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3224     +/-   ##
=======================================
- Coverage   80.8%   80.7%   -0.2%     
=======================================
  Files        128     128             
  Lines      23288   23195     -93     
=======================================
- Hits       18821   18719    -102     
- Misses      4467    4476      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bantonsson bantonsson force-pushed the ban/remove-tracing-otel-dependency branch 3 times, most recently from 104b3f7 to 093d96d Compare November 6, 2025 09:11
@bantonsson bantonsson force-pushed the ban/remove-tracing-otel-dependency branch from 093d96d to 3b70f41 Compare November 6, 2025 09:12
@bantonsson bantonsson requested a review from cijothomas November 6, 2025 09:33
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and we should be now unblocked to do rest of clean up for OTel Tracing API!

@cijothomas
Copy link
Member

@dylanahsmith FYI, since you helped fix the issue originally. Given tracing-opentelemetry now properly activate OTel Span Context, this is no longer required. If any surprises comes, please do open an issue.

@cijothomas cijothomas merged commit c75413c into open-telemetry:main Nov 6, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Remove circular dependency from core repo

3 participants