Skip to content

Fix use of link.attributes.dropped, which may not exist #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix use of link.attributes.dropped, which may not exist #4119

merged 1 commit into from
Aug 13, 2024

Conversation

@kevinji
Copy link
Contributor

@kevinji kevinji commented Aug 13, 2024 •
edited
Loading

Description

A bug was introduced in #3618 as .dropped only exists on BoundedAttributes, not the base Attributes.

Similar to #3965, add a new dropped_attributes property to Link.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a unit test

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@kevinji kevinji requested a review from a team August 13, 2024 04:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kevinji / name: Kevin Ji (0c44098)

@kevinji
Fix use of link.attributes.dropped, which may not exist
0c44098 
A bug was introduced in #3618 as `.dropped` only exists on
`BoundedAttributes`, not the base `Attributes`.

Similar to #3965, add a new `dropped_attributes` property to `Link`.
@lzchen lzchen merged commit 9a20504 into open-telemetry:main Aug 13, 2024
@kevinji kevinji deleted the fix-link-attributes-dropped branch August 13, 2024 17:05
@kevinji
Copy link
Contributor Author

kevinji commented Aug 13, 2024

@lzchen (or another maintainer): Do you think you can cut a release with this bug fix? It is causing some runtime exceptions at the moment.

@lzchen
Copy link
Contributor

lzchen commented Aug 13, 2024

@kevinji

This will be part of our monthly release cadence which should be around the first week of September.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

+1 more reviewer

@bobbychen2000 bobbychen2000 bobbychen2000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinji @lzchen @bobbychen2000