Re add toplevel py.typed file #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the toplevel opentelemetry module is marked as typed
xrmx
approved these changes
Jul 26, 2024
emdneto
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will ensure that the top-level opentelemetry module is marked as typed.
This was removed as part of #3385
where py.typed files were correctly added to submodules. However, a file at the top level is also required
In 1.26.0 if you try to to run pyright against a simple line such as:
from opentelemetry import traceThis will fail with an error such as
An example of this failing can be seen in microsoft/Qcodes#6279
Type of change
How Has This Been Tested?
Manually ran pyright against code that fails with 1.26.0 against main branch with this fix and confirmed that error is gone
Does This PR Require a Contrib Repo Change?
Checklist: