Add test case for child-parent exception handling #3356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For the time being, this PR does not change anything in the SDK, it only adds a test case that verifies the current behavior. This is what I coud find in the spec:
(Emphasis is mine) I'll bring this to the next SIG for discussion. |
aabmass
approved these changes
Jun 29, 2023
This tries to clarify the behavior that should happen when there is an exception raised in a child span which has been started with record_exception and set_status_on_exception to False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to clarify the behavior that should happen when there is an exception raised in a child span which has been started with record_exception and set_status_on_exception to False.
See #3252.